#30511: Remove OnIceComplete -------------------------------------+------------------------------ Reporter: arlolra | Owner: (none) Type: defect | Status: needs_review Priority: Low | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------+------------------------------
Comment (by dcf): I'm trying to understand the change around `pc.CreateAnswer`: https://github.com/keroserene/snowflake/compare/ice#diff- e32e5d12043e17d487f1252ee61dfd5fL167 Was it always unnecessary to run `pc.CreateAnswer()` in a goroutine? Is the removal of `errChan` and `answerChan` a separate cleanup, or is it necessitated by the removal of `OnIceComplete`? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30511#comment:3> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs