#30511: Remove OnIceComplete -------------------------------------+------------------------------ Reporter: arlolra | Owner: (none) Type: defect | Status: needs_review Priority: Low | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------+------------------------------
Comment (by cohosh): Also noting that with the current implementation, `pc.CreateAnswer` won't block indefinitely. It will time out and return `nil` after 3 seconds: [https://github.com/keroserene/go- webrtc/blob/a1272c08ab1d5ca154c6794ddc5f73d2e576fe1b/peerconnection.cc#L355 peerconnection.cc#L355]. It might be better practice to include our own timeout and not rely on the underlying implementation, at the very least we should document that this method times out since right now the documentation only mentions that it is blocking: https://godoc.org/github.com/keroserene/go- webrtc#PeerConnection.CreateAnswer I left the [https://github.com/cohosh/snowflake/blob/master/proxy- go/snowflake.go#L317 comment] to note that we might want to change this later. Otherwise the patches look good to me. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30511#comment:5> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs