#31992: Remove apktool workaround in #31564 --------------------------------------+-------------------------- Reporter: gk | Owner: tbb-team Type: defect | Status: new Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-rbm | Actual Points: Parent ID: | Points: 0.25 Reviewer: | Sponsor: --------------------------------------+--------------------------
Comment (by boklm): Replying to [comment:12 sisbell]: > Replying to [comment:11 gk]: > > Replying to [comment:7 sisbell]: > > > Replying to [comment:6 gk]: > > > > [snip] > > > > > > 2) I am a bit confused about the approach of picking a newer `apktool` .deb in the face of Debian's [bug 942019 https://bugs.debian.org /cgi-bin/bugreport.cgi?bug=942019]. How would that .deb work around the problem mentioned there? > > > > > > Given the one from the internet works and the one in buster doesn't, it is unlikely to have anything to do with aapt itself (which is the same in both cases), as suggested in the bugreport. > > > > Could you expand on that comment as I don't understand how it addresses my question? How are we avoiding the problem if we download the .deb with all dependencies from Debian if using the that .deb is problematic? > > ApkTool is really just a wrapper around a bunch of other libraries. It's the dependent libraries we need to update. For example, we know that the deb will use smali-lib 2.2.1 (which is part of the set of older libraries with the problem) but is compatible with 2.3. So I was thinking if we can install something like libsmali-java 2.3, ApkTool should work. What makes you say that the issue is with the smali version? When I unzip the `apktool_2.4.0.jar` we currently use, I can see that the file `smali.properties` contains: {{{ application.version=2.2.6 }}} So it seems that `apktool_2.4.0.jar` includes smali version `2.2.6`. And the `libsmali-java` package in buster is version `2.2.6` too, so it looks like we are using the same smali version in both cases. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31992#comment:13> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs