#28745: THE Torbutton clean-up -------------------------------------------------+------------------------- Reporter: gk | Owner: acat Type: defect | Status: | needs_review Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-torbutton, | Actual Points: TorBrowserTeam201911R | Parent ID: #30506 | Points: Reviewer: | Sponsor: -------------------------------------------------+------------------------- Changes (by acat):
* status: assigned => needs_review * keywords: tbb-torbutton, TorBrowserTeam201911 => tbb-torbutton, TorBrowserTeam201911R Comment: Thanks for the review. Revised branch: https://github.com/acatarineu/torbutton/commits/28745+3. With respect to the `k_tb_browser_update_needed_pref` comment, I decided to squash `Remove versioncheck from torbutton.js` and `Remove code dealing with torbutton UI button in toolbar`, as some of the requested changes were already included in the other commit, and I think these are related (we can remove versioncheck because there is not torbutton UI anymore). There were some conflicts with the last commit of 28745+2 (2d318efde8faccf3980c6d7da163c32103202b26) and the 46efc92348dbed06fc31ddfb0a5ac2e4e8554de2 commit in master (#30237). I think these are not straightforward to solve, as in that commit I moved `m_tb_control_ipc_file, m_tb_control_host, m_tb_control_port, m_tb_control_pass, m_tb_control_desc` to a service while in the master commit those were moved to a different module and initialized via `configureControlPortModule`. I would suggest dropping that commit for now, and perhaps do it later in #30850 (some of the previous dropped commits are also related to that one). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28745#comment:22> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs