#15395: add support for more than 40 results
----------------------------------------------+----------------------------
Reporter: cypherpunks | Owner: phw
Type: defect | Status:
Priority: Medium | needs_review
Component: Metrics/Atlas | Milestone:
Severity: Normal | Version:
Keywords: complete-before-abandoning-globe | Resolution:
Parent ID: | Actual Points:
Reviewer: | Points:
| Sponsor:
----------------------------------------------+----------------------------
Comment (by hellais):
So looking back at actually properly fixing this and not just making a
workaround, I realised that the true issue lied in the fact that a full
page-re-render was being done every time a relay was being looked up.
This obviously lead to terrible performances.
By delaying the rendering of the page of results until all the relays have
been looked up there is a noticeable performance benefit:
https://github.com/hellais/atlas/commit/4da8ad27333efb72eddcc69bad5fb42c15b740bc.
I think there is probably a better way of doing this by leveraging by
doing some two-way data binding in backbone (in angular this is quite
trivial to do, but in backbone there a slight bit more work to do it
properly: see: http://stackoverflow.com/questions/12604834/two-way-data-
binding-in-backbone-js)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15395#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
