#15395: add support for more than 40 results ----------------------------------------------+---------------------------- Reporter: cypherpunks | Owner: irl Type: defect | Status: Priority: Medium | needs_review Component: Metrics/Atlas | Milestone: Severity: Normal | Version: Keywords: complete-before-abandoning-globe | Resolution: Parent ID: | Actual Points: Reviewer: | Points: | Sponsor: ----------------------------------------------+---------------------------- Changes (by irl):
* status: accepted => needs_review Comment: {{{ Allow returning up to 500 search results and error on empty search * Added the ability for errors to be passed along when rendering result sets, to display an error or warning message while still allowing a result set to be rendered. * Results are only rendered once all the requests have succeeded (or failed), not every time there is a response. This greatly improves the performance and now up to 500 results can be rendered reasonably. * Limits the result set to a maximum of 500 results, introducing a new error message when this number is exceeded. (Fixes: #15395) * Introduces a new error message when an empty string is passed and fixed the rendering of that error message by displaying it. (Fixes: #19372) * Thanks to karsten and hellais for their help on this patch. (: }}} https://github.com/irl/atlas/commit/b2ac2eeed6afbf984124b52d79582b98b82f70d7 I think this solves everything. Example in action: http://irl.github.io/atlas/#search/country:de Tested locally quite extensively, and accidentally also fixed #19372 as a side-effect. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15395#comment:10> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs