Hi David, great proposal! Sorry I'm juggling too many things right now to really really review it. Quick skim though looks great. One quick thought is that the HS_DESC event has an optional positional argument (DescriptorID). This is fine *but* I'd advise against it since it will prevent you from ever adding more positional arguments in the future. Making it a key=value argument instead sidesteps this.
On Mon, Nov 6, 2017 at 6:59 AM, David Goulet <dgou...@ev0ke.net> wrote: > Hi everyone, > > Attached is the proposal draft for the hidden service v3 contro port > specification. > > The idea with this proposal is to _only_ extend the current commands and > events to v3. Nothing new is added. We can think of more things to add after > but for now, I wanted a baseline to start with that is only extending what > exists. > > Any kind of feedbacks is welcome! :) > > Cheers! > David > > -- > Zu3IyL4LcdnKNkQIZqEqaTNUapUEJFdEcN02dPwo5FQ= > > _______________________________________________ > tor-dev mailing list > tor-dev@lists.torproject.org > https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev > _______________________________________________ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
