On Mon, Jul 20, 2009 at 4:39 AM, Mads Kiilerich<m...@kiilerich.com> wrote: > On 07/20/2009 01:35 AM, Steve Borho wrote: >> >> GPLv2 is the intended license. I'll adopt Mercurial's header style. >> Do I need to make these changes on the stable branch in order for >> 0.8.N to be considered for inclusion? >> > > I think such a clear statement will be sufficient. Thanks! > > But I guess such a no-risk change would be a good candidate for the stable > branch.
I have applied this change to the stable branch. >>> A couple of files do seem to be derived from Python. They says "See >>> LICENSE-PSF& LICENSE for details". That is problematic because there are >>> no >>> such files in TortoiseHg: >>> thgutil/iniparse/config.py >>> thgutil/iniparse/compat.py >>> >> >> This is http://code.google.com/p/iniparse/. We use it entirely >> unmodified. Bundling it was the simplest solution at the time since >> the project only had a tarfile. I see they now have .deb and .rpm >> packages so an option would be to simply add iniparse as a dependency >> and add iniparse to thg-installer for Windows builds. >> > > Ok. For now I will just remove them from the package. > > As a short term solution I think the missing license files should be added > to the iniparse directory together with an explanation and references to > upstream. I'm leaning towards removing iniparse from the repository and making thgconfig gracefully fail if it cannot import that package. It should just give the user an URL to their website. Not many Unix users use this tool. We would still package iniparse with our Windows installers so those users would see no change. On a separate note, I've changed the MANIFEST.in file to include the translation source files (i18n/*.po) in the tar file so that the debian package builder can compile the translations itself. If the RPM build script could do the same, I could remove the compiled locales directory from the tarball. -- Steve Borho ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
