On 08.09.2009 21:25, Steve Borho wrote:
> On Tue, Sep 8, 2009 at 2:16 PM, Douglas Philips<d...@mac.com> wrote:
>> Forgot to cc the list.
>>
>> On 2009 Sep 8, at 2:55 PM, Steve Borho wrote:
>>> Doubt it.  When 1.3.2 is released we'll probably do an 0.8.3.
>> Hmmm, thought maybe 0.8.2.1, but I guess that is getting a bit
>> ridiculous. :)
>>
>>> There haven't been any code changes to the stable branch in a while.
>>> But I'll generate new nightly builds this evening.
>> Hmmm, ok. Last nightly build I tried, THg wasn't reading the C:
>> \Program Files\TortoiseHg\Mercurial.ini so my kdiff3 visual diff
>> wasn't being configured/used. I've watched the commit messages and
>> don't recall seeing a fix yet, but maybe I missed it.
> 
> Fixed in ad7d3f536c6f
> 
>>> to make thgtaskbar crash when the installer tries to kill it.  I'm
>>> guessing we'll need a cleaner shutdown mechanism, but I don't consider
>>> this a blocker for 0.8.2.
> 
>> ok. I'll still advise my team to uninstall the old one, reboot, and
>> install the new one, at least for the 0.8.x series.

That's the safest way, but see below.

> It doesn't cause any problems, it's just "messy".  If you have visual
> studio installed it will ask you if you want to debug the crash.  If
> you don't want to see it crash, closing the task bar app before
> running the installer will work just as well as uninstalling first.

I'm not that sure it doesn't cause any problems, as thgtaskbar.exe
might prevent removal/replacing of libs (if it is still running).

Maybe we should disable
http://bitbucket.org/tortoisehg/stable/changeset/c0bf32d19be6/
for 0.8.2, and re-enable it later, when that "crash" problem has been fixed.

The following simple change should give you the old window that requests
the user to terminate the app himself before installing.

diff --git a/contrib/win32/mercurial.iss b/contrib/win32/mercurial.iss
--- a/contrib/win32/mercurial.iss
+++ b/contrib/win32/mercurial.iss
@@ -18,6 +18,7 @@ AppSupportURL=http://bitbucket.org/torto
 AppUpdatesURL=http://bitbucket.org/tortoisehg/stable/
 AppID=TortoiseHg
 AppContact=Steve Borho <st...@borho.org>
+AppMutex=thgtaskbar,Global\thgtaskbar
 OutputBaseFilename=TortoiseHg-{#VERSION}
 DefaultDirName={pf}\TortoiseHg
 SourceDir=..\..



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to