On 08.09.2009 21:51, Benjamin Pollack wrote:
> On Tue, 08 Sep 2009 15:43:20 -0400, Adrian Buehlmann <adr...@cadifra.com>
> wrote:
>
>> Maybe we should disable
>> http://bitbucket.org/tortoisehg/stable/changeset/c0bf32d19be6/
>> for 0.8.2, and re-enable it later, when that "crash" problem has been
>> fixed.
>>
>
> Given that I'm sending the same message Windows sends on shutdown, it
> seems to me that we must be crashing on log-out, too, in which case this
> makes more sense to fix by repairing the crash, rather than just disabling
> its most obvious manifestation. I'll put my code where my mouth is and
> try to get a patch out by this evening or tomorrow morning; if I fail, go
> ahead and remove the patch.
Excellent, thank you.
I just tried logout, but I can't find any crash signs (tried with
having had the options dialog opened and closed again too).
One hunch I have is that it might still be a timing problem.
Maybe the installer starts removing the files too soon?
(Although I tried to work a bit against that in 7cda7b77c69b --
see the Sleep in function TerminateThgTaskbar).
Please also note that in 7cda7b77c69b I removed the global
"restartreplace uninsrestartdelete" for exe's and dlls
(because 7cda7b77c69b introduces install without shell extension, which
should work without restart):
diff --git a/contrib/win32/mercurial.iss b/contrib/win32/mercurial.iss
--- a/contrib/win32/mercurial.iss
+++ b/contrib/win32/mercurial.iss
[snip]
@@ -56,33 +66,34 @@ Source: ..\contrib\*.exe; DestDir: {app}
Source: ..\contrib\*.dll; DestDir: {app}; Flags:
Source: ..\contrib\TortoiseOverlays\*.*; DestDir: {app}/TortoiseOverlays;
Source: contrib\refreshicons.cmd; DestDir: {app}/contrib
-Source: dist\*.exe; DestDir: {app}; Flags: ignoreversion restartreplace
uninsrestartdelete
-Source: dist\*.dll; DestDir: {app}; Flags: ignoreversion restartreplace
uninsrestartdelete
+Source: dist\*.exe; Excludes: "thgtaskbar.exe"; DestDir: {app}; Flags:
ignoreversion
+Source: dist\thgtaskbar.exe; DestDir: {app}; Flags: ignoreversion; Components:
shell
+Source: dist\*.dll; DestDir: {app}; Flags: ignoreversion
Source: dist\library.zip; DestDir: {app}
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
