On 19.09.2009 10:00, Yuki KODAMA wrote: > On Sat, Sep 19, 2009 at 16:02, Adrian Buehlmann <adr...@cadifra.com> wrote: >> On 19.09.2009 08:10, Yuki KODAMA wrote: >>> # HG changeset patch >>> # User Yuki KODAMA <endflow....@gmail.com> >>> # Date 1253340552 -32400 >>> # Node ID 2e75c17874ab1e6f5d5b65caefaf4be5152cecb3 >>> # Parent f52684e023c2a6a8c0a2a4e8ef9e750c8f464764 >>> status: desensitize all tabs >>> >>> Not only text diff and hunk selection tabs. >>> >>> diff --git a/tortoisehg/hgtk/status.py b/tortoisehg/hgtk/status.py >>> --- a/tortoisehg/hgtk/status.py >>> +++ b/tortoisehg/hgtk/status.py >>> @@ -900,11 +900,10 @@ >>> return >>> row = paths[0] >>> >>> - # desensitize the text diff and hunk selection tabs >>> - # if a non-MAR file is selected >>> + # desensitize the tabs if a non-MAR file is selected >>> status = model[row][FM_STATUS] >>> enable = (status in 'MAR') >>> - for pn in [0, 1]: >>> + for pn in range(self.diff_notebook.get_n_pages()): >>> child = self.diff_notebook.get_nth_page(pn) >>> if child: >>> child.set_sensitive(enable) >>> >> Can you explain a bit more why you want this change? >> >> I deliberately didn't do this because, for example the >> "Preview Selection" tab is independent of a file selection >> anyway (I mean the blue selection). >> >> It shows all changes, not matter what file is selected. >> >> Text diff and hunk selection show the (blue) selected file. >> That's why I turned them off if a file that has no diff >> is blue-selected. > > Ah, you're right, it's independent of file selection. > I hope to turn down this patch. Thank you Adrian. >
I'm beginning to think that these tabs are a bit confusing. Some contain the changes for all files, some just for the a single file. My main motivation for adding the "Text Diff" tab was, that I wanted to have a diff where I am able to select text parts, so I can copy things out of it and paste it into, for example, the commit message. Then Steve added the "Preview Selection" tab and there seems to be a "Shelve Contents" tabs (seems to appear only when starting the shelve tool). It looks like my original goal for adding "Text Diff" (being able to copy/paste stuff from the diff) is now covered with the "Preview Selection" tab as well. The only difference of "Preview Selection" to the "Text Diff" tab is, that in "Preview Selection" I see the diffs for all files, where in "Text Diff" I have only one file (the one I "blue-selected"). I think this is redundant now. Having the "Preview Selection" tab is enough to copy text from. So I think we can eliminate the "Text Diff" tab. Next thing that itches me is the name "Preview Selection". The term "Selection" is a bit confusing. There are three distinct forms of selection: (1) click on a file in the files list (I coined the term "blue-selection") (2) checkmark boxes in the files list (3) selecting hunks in the "Hunk Selection" tab Maybe we can find some better name for the "Preview Selection" tab. How about "Commit Preview"? ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
