On Sat, Sep 19, 2009 at 4:25 AM, Adrian Buehlmann <adr...@cadifra.com> wrote: > On 19.09.2009 11:14, Adrian Buehlmann wrote: >> I'm beginning to think that these tabs are a bit confusing. >> >> Some contain the changes for all files, some just for the >> a single file. >> >> My main motivation for adding the "Text Diff" tab was, that >> I wanted to have a diff where I am able to select text parts, >> so I can copy things out of it and paste it into, for example, >> the commit message. >> >> Then Steve added the "Preview Selection" tab and there seems >> to be a "Shelve Contents" tabs (seems to appear only when >> starting the shelve tool). >> >> It looks like my original goal for adding "Text Diff" (being able >> to copy/paste stuff from the diff) is now covered with the "Preview >> Selection" tab as well. >> >> The only difference of "Preview Selection" to the >> "Text Diff" tab is, that in "Preview Selection" I see >> the diffs for all files, where in "Text Diff" I have >> only one file (the one I "blue-selected"). >> >> I think this is redundant now. Having the "Preview Selection" >> tab is enough to copy text from. >> >> So I think we can eliminate the "Text Diff" tab. > > Hmm. I forgot merges. > > For merges we currently show only the "Text Diff" tab > containing: > > ===== Diff to first parent ===== > ... > ===== Diff to second parent ===== > ... > > Maybe we should put that into the "Commit Preview" > tab in the case of a merge and present only that tab > in this case.
Seems reasonable. >> Next thing that itches me is the name "Preview Selection". >> >> The term "Selection" is a bit confusing. There are three >> distinct forms of selection: >> >> (1) click on a file in the files list (I coined the term >> "blue-selection") >> (2) checkmark boxes in the files list >> (3) selecting hunks in the "Hunk Selection" tab >> >> Maybe we can find some better name for the "Preview >> Selection" tab. >> >> How about "Commit Preview"? If it can be renamed to 'patch preview' in qnew/qrefresh mode, I would be ok with 'commit preview'. There was also the issue of showing just working copy diffs of the currently selected file when in qrefresh mode. Perhaps that should be another tab.. dunno. -- Steve Borho ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
