Hmm... well, this is a somewhat more ambitious patch, which essentailly converts over all uses of repo.invalidate() to use hglib.invalidate()
Most times when repo.invalidate was called, the dirstate was NOT refreshed as well; since I'm working on the assumption that this was intentional, I added a flag to invalidaterepo which can disable the dirstate.invalidate() portion. The net effect is that now anywhere we were invalidating the repo, we are now also invalidating mq and bookmarks, which I'm assuming is generally desired (it certainly is in the case of bookmarks). Also, if in the future we need to invalidate other information, we now can do so from a central place. I realize this is a somewhat further-reaching patch than the others I've submitted, and it's possible there's some subtlety here I'm missing, so you'll probably want to take a closer look at it before incorporating it. - Paul On Thu, Dec 17, 2009 at 5:35 PM, Steve Borho <st...@borho.org> wrote: > On Thu, Dec 17, 2009 at 5:17 PM, Paul Molodowitch > <pa...@luma-pictures.com> wrote: > > Just a patch which makes TreeModel.refresh use hglib.invalidaterepo, > instead > > of repo.invalidate, so bookmarks are properly reset. > > > > By the way, is there a reason why repo.invalidate is still being used > > instead of hglib.invalidaterepo? I ask because I'm worried that if I > don't > > go through and replace most uses of repo.invalidate with > > hglib.invalidaterepo, fringe cases where bookmarks aren't refreshed will > > keep popping up... > > If you know that only a certain portion of the repository needs to be > invalidated (the dirstate, for instance), you could do that > specifially, but in general I think we want to use the hglib version. > > -- > Steve Borho >
invalidateRepoSmash
Description: Binary data
------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
