On Thu, Dec 1, 2011 at 6:45 AM, Sune Foldager <cyan...@me.com> wrote: > On 01-12-2011 05:39, Steve Borho wrote: >> >> On Wed, Nov 30, 2011 at 5:30 AM, Sune Foldager<cyan...@me.com> wrote: > >>> [...] > >>> The line you pointed to above doesn't seem to define any colors that lets >>> me >>> override the use of status.modified etc. It's not the same as >>> log.modified; >>> I'm talking about status (as in the commit window), not log. >> >> >> So you would add: >> >> [thg-colors] >> status.modified = GUI-COLOR >> >> and those would override any configuration you had for >> >> [color] >> status.modified = CLI-COLOR >> >> What am I missing? > > > Ah, that makes more sense, thanks. I assumed the overrides in the code were > added to the existing color section, implicitly. > > I still think thg-color shouldn't inherit from color, since it in general > doesn't make sense. Wouldn't it be better to just fix thg-color internally > to be identical to the default color (except for the change done in the cset > mentioned)? Again, people use color for white-on-black, and thg displays > black-on-white. > > TL;DR: color and thg-color have different domains, IMO, and doing > inheritance between them will probably almost always give the wrong result.
I dunno, red is red so long as they're not mucking with the background colors. I see your point but it would break backward compatibility for something that can be resolved with a bit more verbiage in your INI file. So I'm at a +0.45 -- Steve Borho ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
