On Thu, 2009-02-12 at 02:22 +0000, TK Soh wrote: > On Wed, Feb 11, 2009 at 6:03 AM, Steve Borho <[email protected]> wrote: > > On Tue, Feb 10, 2009 at 11:54 PM, Steve Borho <[email protected]> wrote: > >> On Tue, Feb 10, 2009 at 10:40 PM, TK Soh <[email protected]> wrote: > >>> On Wed, Feb 11, 2009 at 4:32 AM, Steve Borho <[email protected]> wrote: > >>>> On Wed, 2009-02-11 at 04:23 +0000, TK Soh wrote: > >>>>> On Wed, Feb 11, 2009 at 4:04 AM, Steve Borho <[email protected]> wrote: > >>>>> > On Wed, 2009-02-11 at 03:39 +0000, TK Soh wrote: > >>>>> >> >> > Partially selected files are now visually noticeable in two > >>>>> >> >> > ways. The > >>>>> >> >> > 'inconsistent' state in the file list now works correctly, on > >>>>> >> >> > Windows > >>>>> >> >> > the box is filled in like in a multiple choice exam. Also, the > >>>>> >> >> > file > >>>>> >> >> > diff header has the tag '** Partial **' added to it. Let me > >>>>> >> >> > know what > >>>>> >> >> > you think about this as well (is the text tag in the right > >>>>> >> >> > place?) > >>>>> >> >> > >>>>> >> >> When a file is partial, it's associated file-list checkbox is > >>>>> >> >> disabled. It should be checked, but with some visual cue to > >>>>> >> >> indicate > >>>>> >> >> partial selection, or, errr, rejection. > >>>>> >> > > >>>>> >> > The checkbox is marked as 'inconsistent', but it's still enabled. > >>>>> >> > Having three states for the check box seems the best visual clue: > >>>>> >> > > >>>>> >> > checked - entire file is selected > >>>>> >> > inconsistent - part of file is selected > >>>>> >> > >>>>> >> What does 'inconsistent' look like graphically? > >>>>> > > >>>>> > On Windows it shows the checkbox filled in with a slightly smaller > >>>>> > solid > >>>>> > box. > >>>>> > >>>>> I don't see it on my Windows box with PyGTK 2.10.6. Does it need a > >>>>> newer version? > >>>> > >>>> Perhaps. I had to rebuild my windows box recently, so I downloaded the > >>>> latest packages off their website. You mentioned you were having > >>>> problems with the file selection dialog with newer versions. What were > >>>> those problems? I should verify I don't have them. > >>> > >>> If indeed the 'inconsistent' checkbox required the latest version of > >>> pygtk, then it's probably not a very good idea to use it, as many > >>> systems out there may be forced to stay with older versions. > >> > >> The docs say it requires GTK+ 2.2. I don't think that's the issue. I > >> did notice that the default style on Ubuntu does not visualize the > >> inconsistent state at all. I had to switch to another desktop style > >> to see it. > >> > >> Ok, what can we use in addition to the inconsistent state? > > > > One idea is to use the radio property. It turns the box into a circle > > with a dot. This property appears to be very mature, and should be > > implemented in every GTK+ theme. > > > > To try it out, just change 'inconsistent' to 'radio' on line 278 of > > status.py. > > > > This is still cleaner than mucking with the filename or adding another > > column > > I just tried your new changes including the use of radio widget. I > think the radio widget is good replacement for now.
Excellent. We can revisit in a later release, if necessary. > The use of italic font on the rejected diff hunks still causes a > little too much flickers for my taste. I took out the italic font, and > feel that removing the diff syntax highlight plus the darker > background can already serve the purpose. So I recommend taking out > the italic font. I agree. > I look at the file header a bit more also. First I think the file > header can use a more distinctive background and/or foreground color > (and bold face?) to differentiate itself, especially now it only > stands out via the use of darker background, which clashes with the > same background used on the rejected hunks. Just wondering, is it > possible to raise the header cells? Also, while we are there, maybe we > can play with the foreground color to reflect the status of hunks > selection too. I looked into raising individual cells (or rows), but there didn't seem to be a way to do that. You can move the text up or down, but you can't do anything like the 'sunken' style you can do on a frame. That is unfortunate. Bold font for the diff headers should be easy to do, as well as their background. I'll take a stab at that yet this evening. I am shading the foreground text of rejected hunks to gray, but maybe not enough yet. -- Steve ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Tortoisehg-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss
