On Thu, 2009-02-12 at 02:22 +0000, TK Soh wrote:
> On Wed, Feb 11, 2009 at 6:03 AM, Steve Borho <[email protected]> wrote:
> > On Tue, Feb 10, 2009 at 11:54 PM, Steve Borho <[email protected]>
> wrote:
> >> On Tue, Feb 10, 2009 at 10:40 PM, TK Soh <[email protected]>
> wrote:
> >>> On Wed, Feb 11, 2009 at 4:32 AM, Steve Borho <[email protected]> >>>
> >>> If indeed the 'inconsistent' checkbox required the latest version of
> >>> pygtk, then it's probably not a very good idea to use it, as many
> >>> systems out there may be forced to stay with older versions.
> >>
> >> The docs say it requires GTK+ 2.2.  I don't think that's the issue.  I
> >> did notice that the default style on Ubuntu does not visualize the
> >> inconsistent state at all.  I had to switch to another desktop style
> >> to see it.
> >>
> >> Ok, what can we use in addition to the inconsistent state?
> >
> > One idea is to use the radio property.  It turns the box into a circle
> > with a dot.  This property appears to be very mature, and should be
> > implemented in every GTK+ theme.
> >
> > To try it out, just change 'inconsistent' to 'radio' on line 278 of 
> > status.py.
> >
> > This is still cleaner than mucking with the filename or adding another 
> > column
> 
> I just tried your new changes including the use of radio widget. I
> think the radio widget is good replacement for now.
> 
> The use of italic font on the rejected diff hunks still causes a
> little too much flickers for my taste. I took out the italic font, and
> feel that removing the diff syntax highlight plus the darker
> background can already serve the purpose. So I recommend taking out
> the italic font.
> 
> I look at the file header a bit more also. First I think the file
> header can use a more distinctive background and/or foreground color
> (and bold face?) to differentiate itself, especially now it only
> stands out via the use of darker background, which clashes with the
> same background used on the rejected hunks. Just wondering, is it
> possible to raise the header cells? Also, while we are there, maybe we
> can play with the foreground color to reflect the status of hunks
> selection too.

All pushed, I believe.

gtk.TextBuffer() widgets have a lot more flexibility than these marked
up text strings.  I saw they have background-stipple and a few other
niceties.  But you can't embed a TextBuffer inside a TreeView.

--
Steve


------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Tortoisehg-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-discuss

Reply via email to