On Fri, Apr 07, 2017 at 11:50:49AM +0200, Roberto Sassu wrote: > On 4/5/2017 4:36 PM, Roberto Sassu wrote: > > I have a question. As you can see in the IMA patch, I'm calling > > tpm_is_tpm2() to determine if I should invoke tpm_pcr_extend(), > > for TPM 1.2, or tpm_pcr_extend_digests(), for TPM 2.0. > > > > Should the new function work with TPM 1.2? If a tpm2_digest > > structure with a SHA1 digest is provided, I could call > > tpm_pcr_extend() instead of returning an error. > > Hi Jarkko > > would you have any objection if the new functions work > regardless of the TPM version? > > Thanks > > Roberto
Yes, you should not add multiple functions that do the same thing essentially. Please rework tpm_pcr_extend instead. And while you are doing it, please also rework it to use tpm_buf for everything. /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
