On Mon, Apr 10, 2017 at 01:46:40PM +0200, Roberto Sassu wrote: > On 4/7/2017 9:31 PM, Jarkko Sakkinen wrote: > > > would you have any objection if the new functions work > > > regardless of the TPM version? > > > > Yes, you should not add multiple functions that do the same thing > > essentially. Please rework tpm_pcr_extend instead. > > This means that callers of tpm_pcr_extend() (pcrlock() > in security/keys/trusted.c) should be modified too, > as the parameters will change.
Yes. You need to do that. > Also, tpm2_algorithms and tpm2_digest, the new arguments of > tpm_pcr_extend(), should be renamed to tpm_*, since > that function will be used regardless of the TPM version. Please do not rename enum tpm2_algorithm as those are the actual TPM 2.0 algorithm identifiers. > tpm_buf_init() should be modified, to be used for TPM 1.2 commands. > tag and ordinal should be written to the buffer in little endian. This is not true. They are in big-endian byte order. > Roberto /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
