On 9/3/07, Eli <[EMAIL PROTECTED]> wrote: > > 1 Anything beyond a 'trivial' bugfix requires a branch. > > 2 A branch must be reviewed and approved by another developer > > before merging to trunk. If something is committed to trunk with > > insufficient review, anyone can backout changes, preferably to a > > branch. > > 3 Branches should have a purpose statement on t.e.o under > > TracDev/Branches and an announcement to trac-dev. > > > > Votes/Comments?
+1. I'd have liked this process before the security merge. The feedback I did get, from osimons and cboos IIRC, was invaluable, but more eyes means better code. Here are some more points I suggest we think about adding: - Requests for code review must be responded to within a timely manner. - Purpose statements/designs should be reviewed as early as possible. - Feedback must be constructive, with well reasoned arguments to back up your position. - Each branch should contain just the changes required to implement your proposal. This makes the reviewers life easier which in turn makes yours easier. These are more just guidelines than anything but I think they're critical to this whole thing working. Particularly the first point. > It is critical that we all make the effort to review other developers' > branches in a timely manner, and provide useful, constructive feedback > as early in the development process as possible. I think this is pivotal and thus should be included in any policy. Having a well defined process is a good idea, but the true change that's needed is constructive, in-depth, early review of design proposals and branches. -- Evolution: Taking care of those too stupid to take care of themselves. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
