On 9/4/07, John Hampton <[EMAIL PROTECTED]> wrote:
> We're kind of in this spot right now with regards to the context stuff
> and security. Security got merged, and I'm glad for that, but it's only
> finished for the wiki. It needs to be extended to the tickets, and
> needs to be done before a release.
Ticket proper has been done for a couple of weeks:
http://trac.edgewall.org/changeset/5958
Query and report are to come.
I don't think I'd do anything differently with security under this
proposed scheme.
I requested review of the branch, got some feedback from cboos and
osimons and integrated them. People had around two weeks to review the
branch before I merged it. The fact that only a couple of people
actually did, illustrates my previous point about how people
*must*/*should* ;) take the time time to review changes if this entire
system is to work.
I specifically kept the differences small by limiting the changes to the
Wiki subsystem. This was so it would be easier to review, and
consequently any problems found would be relatively easy to fix.
The real problem was that my life became significantly busier and I was
unable, until recently, to dedicate enough time to it. Not much one can
do about RL intruding.
> > Something like
> > http://trac.edgewall.org/log?action=stop_on_copy&rev=5069&stop_rev=5065 ?
> >
> > Backing out others change is not a good idea. Even if you have good
> > intents (as this was the case above), it won't be perceived that way.
>
> Well, it seems that this only points to the fact that the Genshi changes
> should have been done in a branch first, and then merged into trunk.
>
> Also, reverting changes should be infrequent, as work should be done on
> branches and then vetted by other devs before being merged. If that
> happens, then there shouldn't be any need to revert changes from trunk.
100% Agreed. The situation cboos points to illustrates exactly *why*
this new proposal is good. It will prevent, or at least minimise,
situations like this.
--
Evolution: Taking care of those too stupid to take care of themselves.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac
Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
