On Sat, Jan 10, 2009 at 08:36:31PM -0500, David Abrahams wrote: > > > on Fri Jan 09 2009, Jeff Hammel <jhammel-AT-openplans.org> wrote: > > > On Fri, Jan 09, 2009 at 08:42:08PM -0500, David Abrahams wrote: > > > >> Couldn't Trac better protect itself from this sort of thing by using a > >> timeout? It could simply bail on inlining anything if it takes more > >> than X seconds. That way, one wouldn't have to try to guess at the > >> number of files or bytes that will cause an apparent hang on particular > >> hardware and source bases. > > > > That seems more the job for the webserver > > How is the webserver going to cause a fallback to a non-inlined display > without the user experiencing an error?
I was under the assumption that the important part was to avoid the runaway processes. But yeah, the webserver or middleware can't magically know about trac's internals (or really shouldn't, in any case). > > or middleware, > > I've never really understood that term, so can't comment. > > > though a plugin would be trivial to implement (IRequestFilter). > > Is this a case of "it can be implemented in a plugin, so it should be?" Probably? Well, yes. I make little differentiation philosophically between components that come with core and components packaged in plugins. But yeah, a plugin seems the right place to put it. Jeff Hammel IRC: jhammel, k0s --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
