Christian Boos wrote: > Besides we can still optimize _content_changes further and especially > the way it takes care of big files: > - instead of reading all the content of the old and new files before > checking if any of those is binary, it could take this decision by > looking at the extension or at the first 1000 bytes, as #3332 did IIRC. > - don't display in-line changes for big files (> 100k?) at all, even > if they're not binary, except of course when viewing a changeset > restricted to that file
Some repo types (e.g. Perforce) also have a file type attribute which can be used to determine if file is binary without having to read the file at all. It would be nice to take advantage of this when its available. -- Justin --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en -~----------~----~----~----~------~----~------~--~---
