On 14.04.2010, at 14:13, Felix Schwarz wrote: > Am 14.04.2010 12:49, schrieb Christian Boos: >> Christopher specifically asked for help for *one* ticket (#370), but >> nobody seems to care so far and this tells a lot. > > I'd like to add that I spent 3-4 hours debugging that issue (as it was a > problem we found in Agilo). I have a couple of (too complicated) unit tests > that uncover the issue. > > The problem exists in the generic strategy. The strange thing is that a > callable is returned from a method and this callable uses a local variable of > that method (basically some extra state for the callable). This extra state > is a stack which underflows due to an unknown condition. > > The problem which seem to overwhelm my python foo/debugging capabilities is > that the problem was introduced in a mass-merge of GSOC work.
Yeah this code is a hairy mess and hell to debug. There are parts of the code developed during GSoC that I have trouble understanding myself. But to be fair, this bug was actually (luckily?) outside the GSoC work. Anyway, I've just attached an 8 byte patch for this issue, along with your test cases: <http://genshi.edgewall.org/attachment/ticket/370/ticket370.diff> I would be very grateful if more people could give this change some testing in the field. All the unit tests are nice and green, but of course that might just mean that we're missing an important test case :P Here's to 0.6 in a few days. Cheers, -- Christopher Lenz cmlenz at gmx.de http://www.cmlenz.net/ -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.
