-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 12.10.2011 09:37, wrote Franz: >> No. Reading source of the suggested plugin raises some 'don't do that' >> for me, but nothing exactly related to the error. > > What are 'don't do that's in that plugin?
PEP8 - noticeable number of lines > 79 chars explicit 0.12 branch, but still old self.env.get_db_cnx() instead of current @self.env.with_transaction() calls _init_config() that forces some configuration settings saves trac.ini each time that post_process_request() is called - insane undefined permission CONTROLLER_ADMIN (well mentioned as ToDo, but what exactly is so hard about adding the few line for a proper implementation of the required AdminPanelProvider method? badly readable (caseless) SQL statement formatting mentions ClearSilver templates, but certainly uses Genshi Just what I saw at first read. Steffen Hoffmann -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6WC/YACgkQ31DJeiZFuHdGpACghUotMSGWRlQdp5Gd2LJ6AOIT uEcAn2958uKkto39D5Z5MKcWvARppWw9 =ZIwt -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.
