On 03.03.2012 17:23, Remy Blank wrote:
> (CC: to trac-dev, we want to have such discussions in public.)
Right, thanks!
> This should probably include moving the few existing unit tests in
> `future27.py` out of the `__main__` section of that file into
> `tests/future27.py` and having it called as part of the normal unit
tests.
I'm wondering, would it be best to drop `future27.py` entirely? It only
defines (and tests) `namedtuple`, which is only used once to define
`Storage.RevCache`. It seems it would be easier to define:
{{{
class RevCache(object):
def __init__(self, youngest_rev, oldest_rev, rev_dict, tag_set,
srev_dict, branch_dict):
self.youngest_rev = youngest_rev
self.oldest_rev = oldest_rev
self.rev_dict = rev_dict
self.tag_set = tag_set
self.srev_dict = srev_dict
self.branch_dict = branch_dict
def __iter__(self):
yield self.youngest_rev
yield self.oldest_rev
yield self.rev_dict
yield self.tag_set
yield self.srev_dict
yield self.branch_dict
}}}
Or is there more to it?
This would also eliminate the license question. (I.e.: Can we commit a
file that says "# Copyright (C) 2001-2010 Python Software Foundation;
All Rights Reserved"?)
> If there are many tickets, we could find a way to import them
> automatically. Otherwise, just copy / paste the relevant ones, and close
> the rest.
There are currently 40 open tickets. At first glance I think we can drop
these:
#8393 Outdated git version
#8102 Python 2.4 only
#6398 0.11 branch only
#7381 Permission problem
#9134 Permission problem
#8844 Permission problem
#9641 Permission problem
#8465 Duplicate of #8682
#8473 Duplicate of #8682
#3888 Duplicate of #6216
#9581 Duplicate of #9560
#7665 No feedback
Which leaves, roughly categorized:
#8944 (unicode, `git_fs_encoding` configuration issue?)
#8087 (unicode, `git_fs_encoding` configuration issue?)
#8639 (linefeeds, PATCH)
#2633 (Feature request: branches)
#7860 (Feature request: branches)
#8522 (Feature request: branches, PATCH)
#2685 (changeset links, Fixed?)
#8937 (changeset links)
#6216 (changeset links)
#8658 (changeset links)
#8354 (changeset links, PATCH)
#9657 (cygwin, PATCH)
#8016 (cache)
#4505 (cache)
#8880 (submodules)
#3842 (submodules, NoneType)
#9552 (NoneType, Ubuntu)
#8682 (Could not retrieve GIT version / NoneType, Ubuntu / OpenSUSE)
#4227 (Could not retrieve GIT version / subprocess, Ubuntu / OpenSUSE)
#9560 (subprocess, with statement, PATCH)
#9646 (subprocess)
#9778 (subprocess)
#8401 (subprocess, not enough info?)
#8260 (bare repo, gitolite)
#9879 (Bitten)
#746 (performance)
#4318 (Documentation)
#8456 (?)
Probably we can merge some more of these as duplicates.
>> Maybe we should open a ticket for this migration itself?
>
> Yes, please do.
Done: #10594
--
Peter
--
You received this message because you are subscribed to the Google Groups "Trac
Development" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/trac-dev?hl=en.
