-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10.04.2013 20:01, Christopher Nelson wrote: >> ... >> As a part of Apache™ Bloodhound Trac fork, we added a new >> IResourceChangeListener interface, which is common for all resources (see >> full code in attached patch). The main idea of the IResourceChangeListener >> interface is that it is similar to existing I*ChangeListener interfaces >> (existing interfaces are working as before), it is common for all resources >> (resource is sent as parameter) and that there is no need to introduce >> interfaces such as IVersionChangeListener, IComponentChangeListener etc. >> Listener may specificy resource types for which it has to be notified via >> method get_subscribed_resources. What do you think about such approach? >> ... > > It seems a fine idea. After a quick skim, the code seems fine. I > wonder thought why you need to notify about ticket changes; surely the > ticket change listener already covers that.
I've already been thinking lately, that it would be nice to implement only one generic change listener instead of one per Trac realm, effectively standardizing the divergent change listener APIs. This is a nice enhancement indeed, and interesting for a number of Trac plugins, that hold additional, complementary information for different Trac resource realm. Just from the top of my head BreadCrumbsNavPlugin, TagsPlugin and TracFormsPlugin might be candidates to profit from such a generic interface. Steffen Hoffmann -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlFls2UACgkQ31DJeiZFuHdLXgCeK2FGPpUoa2HXZb6Oth/lCrmR ULYAoKOBWkIoTRYQwz1DVuGb/1dWXSGr =1suw -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/trac-dev?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
