On 4/10/13, Andrej Golcov <[email protected]> wrote: >> Yes, it's nice. The "context" however in the IResourceChangeListener can >> be confused with a RenderingContext which is often passed as "context" >> as well. Maybe changecontext? or changeinfo? > Interesting that Olemis pointed out the same issue on bloodhound-dev > mailing list. I hope he will join this discussion also. > > I agree about possible confusion with parameter named "context". I'm > thinking towards "event_context" name but I'm aslo fine with suggested > "changecontext" or "changeinfo". >
Like I just said before in [email protected] [1]_ [2]_ this would be a point that would be noticed immediately by people familiar with Trac code base . JFTR , in here I also suggested : 1. evt (dojo) 2. eventObject (jquery) 3. EventArgs (C#) 4. ... <= which is where "event_context" , "changecontext" or "changeinfo" would fit . >> Very much, thanks for thinking about contributing this one back. >> You should open a ticket with that patch (against 1.1.2), so that we can >> follow the progress of the integration, and discuss this further if >> needed (discussion here on trac-dev is welcome as well). > Sure, I'll do it. > During some time I've noticed some things that have not been included in the patch and I'd also like to put under your consideration as well . I'll prepare a summary with references to previous discussions we've had in [email protected] .. [1] Re: Transaction resource changing events (http://goo.gl/0gthX) .. [2] Re: Transaction resource changing events (http://goo.gl/R8kh8) -- Regards, Olemis. Apache™ Bloodhound contributor http://issues.apache.org/bloodhound Blog ES: http://simelo-es.blogspot.com/ Blog EN: http://simelo-en.blogspot.com/ Featured article: -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/trac-dev?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
