On 08/12/2013 12:29 PM, Christian Boos wrote: > On 8/10/2013 10:29 PM, Eli Carter wrote: >> part3: uncache previous_rev() >> Makes previous_rev() unconditionally go to the repository without >> hitting the node_change table. (Was "part3a".) > > I would prefer that you keep the previous code, but commented out, and > the comment saying in addition "commented out for now", making it clear > this is a workaround for the way the SQL query is currently implemented. > That clearly shows that we tried to use the cache, should anyone want to > improve speed by using the cache again.
I've expanded the comment to explain why hitting the database is slow, and under which conditions it is slow; and why hitting the repository directly is the better choice. I've also included the original code commented out. I did not say "commented out for now" because I think this approach is the right solution, not just a workaround for slow SQL. Hopefully that's ok... Committed part3 (as described above) to 0.12-stable, 1.0-stable, and trunk. Eli -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/groups/opt_out.
