On Sat, Aug 17, 2013 at 1:46 AM, Eli Carter <[email protected]> wrote: > On 08/14/2013 10:42 PM, Jun Omae wrote: >> I tried performance tuning of `_next_prev_rev`, tuning-_next_prev_rev.diff. >> >> a. If the node is a directory, don't check changes of node children. > > I think you meant "only if the node is a directory, check changes of > node children"?
That means... If the node is a file, the node has no node children. So, that's no need to check changes of node children. If the node is a directory, the node might have node children. Therefore, we must check changes of node children. ---- Well, I don't have a large repositories for the test cases. > The testcase you're timing has revisions 8734 < 8802 < 11493; I'm not > sure that's going to demonstrate the problem very well. However, I don't think so. The "← Previous Revision" navigation in php.py?rev=8802 page is not a link. So, the _next_prev_rev method for "Previous Revision" searches node_change table from r8802 to r1 and it returns None. (php.py has been moved in r8802) > It does > demonstrate that you've improved its performance in the common case > though, which is good. Yeah, my patch is a small improvement. -- Jun Omae <[email protected]> (大前 潤) -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/groups/opt_out.
