-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 21.11.2013 13:49, Ian Clark wrote: > Hi all, > > Looking at the *grouped_stats_data()* method in roadmap.py:340 > <http://trac.edgewall.org/browser/trunk/trac/ticket/roadmap.py#L340> > it seems as though it would be more optimal to add a break clause > after line 357 if we've found our field.
You could proof me wrong by facts (profiling) here, but my guess is, that the saved string comparisons would only matter with a really high number of ticket (custom) fields. One could add the break anyway, but for this to happen the best way would be opening an enhancement ticket against the report module and adding a ready-made patch to apply. That's how Trac developers use to work [1]. Anyway thanks for discussing your observation. Steffen Hoffmann [1] http://trac.edgewall.org/wiki/TracDev/SubmittingPatches -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlKOD4sACgkQ31DJeiZFuHfz3gCfU6Vi4I7zeLySdxtnPulf8jUC 7ocAn104H/n01dWnvgtuANNpeYR1w3dZ =Wp2o -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "Trac Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/trac-dev. For more options, visit https://groups.google.com/groups/opt_out.
