Hello,
On 12.01.2017 17:31, Christian Boos wrote:
A demo instance is available:
https://trac.edgewall.org/testing
I stumbled on this:
https://trac.edgewall.org/testing/admin/spamfilter/bayes
Trac detected an internal error: TemplateNotFound: jadmin_bayes.html
I guess all admin panels are assumed to use Jinja templates (but the
plugin ones don't)?
https://trac.edgewall.org/browser/cboos.git/trac/admin/web_ui.py?rev=jinja2-trunk-r15341&marks=96,97,109#L72
Can IAdminPanelProvider.render_admin_panel() get a similar legacy mode
as IRequestHandler.process_request?
The plugins making use of Genshi templates won't need to be changed a
bit, while those which want to port to or start using Jinja2 templates
will have to use a new API: `IRequestHandler.process_request` methods
will have to return a `(template, data)` pair instead of the legacy
`(template, data, None)` triple.
The difference seems quite subtle. But I guess it's tricky to be more
explicit without breaking backward compatibility or introducing an ugly
wart for the new way.
One tiny, tiny thing:
https://trac.edgewall.org/browser/cboos.git/trac/util/html.py?rev=jinja2-trunk-r15341&marks=383#L379
"will be in" -> "will be removed in"?
Unfortunately I can't do a more substantial review, sorry, but from what
I read this sounds great.
Peter
--
You received this message because you are subscribed to the Google Groups "Trac
Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/trac-dev.
For more options, visit https://groups.google.com/d/optout.
