On Mon, 2006-06-26 at 15:39 +0200, [EMAIL PROTECTED] wrote: > Hi, > I insert my own comments directly into the database with a cronjob. This > causes a lot of problems with the new reply-feature (which is great by the > way!). Mainly the issue is that inserting an old or future comment (to > force its placement at top or bottom) will break the numbering scheme. > > So I ask two things: > 1. Alter the code so that oldvalue='<NUM>' will not be set, since it seems > not to be needed for anything. > 2. Alter the code so that oldvalue='<replied to>.<current>' is changed to > use relative numbers such as '-1.0'. > > I hope this request won't upset the code base too much. It would make the > database robust to changes where comments are inserted at the top or > bottom. > > Alternatively an auto_increment row ID could be added and used for > referencing. That would make the database completely robust and allow > sorting the changelog by author, for instance.
The comment numbers are not just used in the database, they may also be used in comments to link to other comments e.g. "see comment:1 and comment:2". Using relative numbers in the comment links would probably be confusing for users. And you can't use relative numbers in the anchor links (the ΒΆ link next to the author's name). Additionally, comments could be deleted (using the TicketDeletePlugin on trac-hacks.org or similar functionality included in a future version), which would break relative numberings. So, relative numbers would cause a variety of problems. Unique numbers could work, but they would be rather inconvenient for use in links: "See comment:3757593". So, the question is: why do you need to add comments to the top or bottom of a ticket? Maybe there's a better way to accomplish your goal without breaking the comment numbering. -- Matthew Good <[EMAIL PROTECTED]> _______________________________________________ Trac-dev mailing list [email protected] http://lists.edgewall.com/mailman/listinfo/trac-dev
