On Friday, 21 June 2013 11:41:54 CEST, Pali Rohár wrote:
Hello, here is new version of password interface which using Jobs
Hi, a couple comments (don't have much time, be back on Monday evening). - Why is the code using inline functions so much? - Looks like the other job-based interfaces I took a look at (KDEPIM's IMAP code, the QtKeychain) use class hierarchies for different types of jobs, e.g. there's a root PasswordJob, and from it the RetrievePasswordJob and StorePasswordJob are derived. I find this cleaner than the enum for a job type. - I've tried to find out how QtKeychain selects the backend to be used, but wasn't successful. My motivation was that it might be easier to provide a dead-simple backend for storing passwords in a plaintext file for QtKeychain that duplicating its API. That might be interesting to investigate. Cheers, Jan -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
