From: Richard Maciel <[email protected]>

Related to coverity CID 10298.

If function obj_delfamily_find_by_familyid code execution path is
the one where an object found is of the TPM type, then the
delfamily_list lock is never released.

Signed-off-by: Richard Maciel <[email protected]>
---
 src/tspi/obj_delfamily.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/tspi/obj_delfamily.c b/src/tspi/obj_delfamily.c
index 340bd59..a2fed27 100644
--- a/src/tspi/obj_delfamily.c
+++ b/src/tspi/obj_delfamily.c
@@ -95,8 +95,10 @@ obj_delfamily_find_by_familyid(TSS_HOBJECT hObject, UINT32 
familyID, TSS_HDELFAM
        *hFamily = NULL_HDELFAMILY;
 
        if (obj_is_tpm(hObject)) {
-               if (obj_tpm_get_tsp_context((TSS_HTPM)hObject, &hContext))
+               if (obj_tpm_get_tsp_context((TSS_HTPM)hObject, &hContext)) {
+                       pthread_mutex_unlock(&list->lock);
                        return;
+               }
        } else
                hContext = (TSS_HCONTEXT)hObject;
 
-- 
1.8.5.3


------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
TrouSerS-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/trousers-tech

Reply via email to