Disclaimer: I could not complie-test or runtime-test these patches right now. This is a pure code-only review of the patches.
The patch seems to be correct. There seems to be a huge inconsistency between UnloadBlob_<primitive> and UnloadBlob_<complex>. It might be worth while to change the parameter order of one to match the other (unless this is a specification-oddity or concerns the ABI). Am Mittwoch, den 09.04.2014, 15:41 -0300 schrieb [email protected]: > From: Richard Maciel <[email protected]> > > Related to coverit CID 10254. > > Blob parameter is the last one instead of the middle one. > > Signed-off-by: Richard Maciel <[email protected]> > --- > src/tcs/rpc/tcstp/rpc_ps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/tcs/rpc/tcstp/rpc_ps.c b/src/tcs/rpc/tcstp/rpc_ps.c > index cd44e66..46b07ef 100644 > --- a/src/tcs/rpc/tcstp/rpc_ps.c > +++ b/src/tcs/rpc/tcstp/rpc_ps.c > @@ -505,7 +505,7 @@ UnloadBlob_KM_KEYINFO(UINT64 *offset, BYTE *blob, > TSS_KM_KEYINFO *info) > UnloadBlob_VERSION(offset, blob, (TPM_VERSION *)&(info->versionInfo)); > UnloadBlob_UUID(offset, blob, &info->keyUUID); > UnloadBlob_UUID(offset, blob, &info->parentKeyUUID); > - UnloadBlob_BYTE(offset, blob, &info->bAuthDataUsage); > + UnloadBlob_BYTE(offset, &info->bAuthDataUsage, blob); > UnloadBlob_BOOL(offset, &info->fIsLoaded, blob); > UnloadBlob_UINT32(offset, &info->ulVendorDataLength, blob); > UnloadBlob(offset, info->ulVendorDataLength, info->rgbVendorData, blob); ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ TrouSerS-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/trousers-tech
