2014-07-09 12:22 GMT+02:00 Cédric Krier <cedric.kr...@b2ck.com>: > On 09 Jul 12:06, Jesús Martín Jiménez wrote: > > 2014-07-09 12:04 GMT+02:00 Cédric Krier <cedric.kr...@b2ck.com>: > > > > > On 09 Jul 11:41, Jesús Martín Jiménez wrote: > > > > https://bitbucket.org/zikzakmedia/trytond-sale_margin/commits/a85edbe77cde8e99d2e60f28fd5337d80c5ff699#Lsale.pyT69 > > > > > > > > > > > > > It was a refactored of the code, adding all existing dependences on > an > > > > inherited method. > > > > > > That's wrong. > > > > > > > > Ok. But, what's wrong? > > I don't know how to say it differentrly: > > You must not add depends on fields that the method doesn't depend on. > > What you do is just breaking the modularity. >
But all those depends are already in the core module [1]. Do you mean is wrong repeat them? [1] http://hg.tryton.org/modules/sale/file/c14cc0ed1c0a/sale.py#l1158 > > -- > Cédric Krier - B2CK SPRL > Email/Jabber: cedric.kr...@b2ck.com > Tel: +32 472 54 46 59 > Website: http://www.b2ck.com/ > -- Jesús Martín Zikzakmedia SL Dr. Fleming, 28, baixos 08720 Vilafranca del Penedès ☏ 93 890 21 08
