Hi, I'd like to submit a couple of patches for Turbine 2.4. The first one moves some initialisation code in DefaultSessionTimeoutValve from its constructor to the initialize() method. Before this change, the 'timeout' field was not being set. Here's a commit message for the patch:
--- The valve's 'timeout' field is now set from within the initialize() method rather than the constructor. It seems that the deserialisation mechanism used to instantiate the valve manages to bypass the constructor. The associated test has also been updated to call initialize() on the test valve immediately after creation. Files modified: src/java/org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java src/test/org/apache/turbine/pipeline/DefaultSessionTimeoutValveTest.java --- The second patch just fixes a unit test that was using a BigDecimal constructor unsupported by JDKs older than version 1.5. Message is: --- Replaced all occurrences of "new BigDecimal(long)", which was only introduced with JDK 1.5, with "BigDecimal.valueOf(long)". Files modified: src/test/org/apache/turbine/util/BaseValueParserTest.java --- Cheers, Peter --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
