x:set WAS: I'd like to help

[Brett Porter]

James Strachan wrote:

From: "Brett Porter" <[EMAIL PROTECTED]>

AFAIK there has never been a 'value' attribute on <x:set> as this tag has
always followed the same tag in JSTL. It always uses select="..." to denote
an XPath selection.

Typo then?

It appears it should just be select instead of value, but changing that yields an error about startElement() already being called. This doesn't seem correct, so I'm thinking it may actually be a bug in ElementTag in Jelly, but haven't had a chance to investigate it. I walked through it in my head since I didn't download all the Jelly deps before leaving :(. Seemed ok - outputAttributes was only set true after invokeBody, so I'm not sure whats going on.

However <j:set var="foo" value="${whatever}"/> on the other hand has always
used the 'value' attribute.

Confusing I know but I thought following the JSTL tags might help folks who
use both getting even more confused.

Makes sense, although prone to typos :)

Might be worth having Jelly validate the whole document instead of just the paths it follows. The bug is only exposed in xdoc with a <tr> that has attributes, but if the whole thing were validated the x:set error would show up first go.

I'm sending a patch to the dev. list that includes a trigger for the bug in the touchstone build.

Cheers,
Brett



--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>