> > >> /**
> > >> * Returns false because transactions are only necessary in postgres.
> > >> */
> > >> public boolean objectDataNeedsTrans()
> > >> {
> > >> return false;
> > >> }
> >
> > instead of doing this, why not just test to see if the Connection object is
> > from postgres? seems easier.
> 
> -1
> 
> The DB adaptor classes are there precisely to avoid having mucky
> DB-specific code in BasePeer.
> 
> Even if it seems appropriate for this example to hardcode knowledge into
> BasePeer, it sets a bad precedent.

I agree that BasePeer shouldn't know about this stuff.  However, if it
applies to 
one database only, does it really belong in Turbine's database adapter
code?
-- 

Daniel Rall <[EMAIL PROTECTED]>
http://collab.net/ | open source | do the right thing


------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to