At 06:25 07/09/2006, Jeremy Boynes wrote:
Thanks for the patch Andy. I do have a few comments that I hope you
can address :-)
I would be the first to admit that its an egregious hack.
Unfortunately some of the things I am trying to do do not yet have
supporting functionality in Tuscany. I'm hoping your expertise can be
brought to bear on some of these issues.
Would it be possible to break this down a little - there are changes
in there to the startup code and to the Spring container - is it
possible to separate those so that there is less to tackle in one go?
Sure, although separating these out in patches is a pain. It means
keeping multiple workspaces which then creates merge headaches for me.
For example, are the startup changes really coupled to renaming the
SpringSCA XSD?
Well, the latter are just obvious typos. Barring those the patch in
its totality supports a specific feature for Spring apps. I can break
it up, but I must admit I was assuming that you or Jim would want to
massage it somewhat anyway. Things move so fast in svn at the moment
that if you don't get patches out quick the world has changed :)
Some of the changes seem cosmetic (e.g. JavaDoc changes) and these
really are easier to review if kept separate.
? I'm not aware of those.
Also some of the changes don't seem to fit our coding style
guidelines. I know we're often lax about that but I felt I should
mention it as we're actively trying to improve. You can check this
fairly easily using the "sourcecheck" profile in Maven ("mvn -o -
Psourcecheck").
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] The plugin 'org.apache.maven.plugins:maven-checkstyle-plugin'
does not ex
ist or no valid version could be found
I'm happy to plug in to IntelliJ whatever is appropriate, I had
assumed that the idea:idea target would do that, but evidently not. I
tried to adjust my settings based on other code (4 spaces for indent,
no tabs) but obviously something is not quite right. Can you point me
at what needs to go in IntelliJ?
I work on 5 or 6 different open source projects, each with their own
coding styles, so bear with me while I context switch.
On a legal front, please can you make sure new files have the correct
header block on them (the new one without a (c) statement). Apache
also prefers that files do not contain @author tags we are following
that guideline.
Sure, sorry. That's a hangover from hacking on Spring.
We've tried real hard to avoid a dependency on a particular logging
framework, clogging in particular due to the conflicts that occur
between different projects (for example, you're including 1.1 but
some of our other dependencies are using older versions).
Can you point me at the recommended way of logging? I could not
immediately find any code that did this.
Getting to the technical stuff, the big question I have is about
passing in a Map of properties. This seems to go against the IoC
principles of SCA, Tuscany and Spring. Did you consider extending
RuntimeInfo e.g. as SpringRuntimeInfo, adding in something like
getApplicationContext() ? Or perhaps better, adding the
Yeah, if there is a better way of doing this I would be glad to use
it. I did what I could to get stuff working without introducing core
dependencies on spring. Extending RuntimeInfo is fine, it means more
changes to the Launcher but I guess that's ok.
ApplicationContext as a component in the runtime that could be
directly used as a dependency?
Not sure how I inject this from outside the runtime. This was my big
problem. In this specific use case, Spring needs to be in the driving
seat, passing to the Tuscany runtime what it needs to do further
wiring. If you can outline an example of how this would work that
would be great. I must admit that the operation of these various
pieces is far from clear from the javadoc, so I'm sure my
understanding is far less than perfect. Do you have any design docs
for the new architecture?
Once again, thanks for the patch. If you do get a chance to look at a
couple of these things I'll be online tomorrow and able to help get
the changes in.
Thanks. I'll be looking at some of the Spring issues Jim came across,
so the patch will be getting bigger :) This is the problem in a fast
moving environment with deadlines to meet...
BTW the patch does actually solve the problem I was aiming at - we
are now able to run Spring webapps and struts apps with Tuscany
wiring at the back end.
Thanks
andy
_______________________________________________________________________
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., its subsidiaries and affiliated
entities, that may be confidential, proprietary, copyrighted and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
