Kelvin, Yes, I have been looking at this for the last couple of days as promised. I will attach a patch to the JIRA later today.
Here is a summary of the changes: - Since HelperProvider API and HelperProviderImpl are in two different OSGi bundles, loaded by different classloaders, HelperProvider doesn't find a default implementation when run under OSGi. I have added a method in HelperProvider to set a default implementation if it has not been already set. I added a bundle activator for the SDO implementation bundle which sets this default implementation for HelperProvider. - I modified some of the OSGi manifest entries for the SDO bundles since they look slightly out of date. - I added two tests, one to run the SDO implementation test suite in a multi-classloader environment, and another to run the SDO implementation test suite inside an OSGi container. SDO continues to use the thread context classloader. When running inside an OSGi container, it will be upto the application bundles to add their bundle classloaders to the TCCL if the application classes/resources should be found by SDO implementation. SDOXMLResourceImpl for instance loads resources using TCCL. The alternative would be for SDO to add all bundles to the TCCL using a bundle listener, or use an alternative resource loading mechanism when running under OSGi, both of which are not very satisfactory. There were no other classloading issues with SDO when running under OSGi (at least as far as I can tell). The OSGi testcase runs the sdo.impl test suite with around 180 tests under OSGi - hopefully these tests exercise most of the code. I had a lot of trouble getting SDO and its dependent bundles (EMF etc.) to run under Apache Felix, since EMF bundles use Require-Bundle of the Eclipse runtime, and these in turn bring in Equinox. At the moment, the SDO implementation bundle is created for the OSGi test with a different manifest than the one which is used by the regular build, since I was not sure if the changes would break SDO running under Equinox. And the tests modify the manifest entries in the EMF jars to remove the dependency on Eclipse. These changes are restricted to the test case, and are specific to running SDO in an OSGi runtime other than Equinox. On 1/4/08, kelvin goodson <[EMAIL PROTECTED]> wrote: > Hi Rajini, > Now that the New Year has arrived, do you think you'll be able to take a > look at this? > Thanks, Kelvin. > > > On 11/12/2007, Rajini Sivaram <[EMAIL PROTECTED]> wrote: > > > > Kelvin, > > > > I am busy until Christmas with the SCA-OSGi work, but I will try and > look > > at > > the OSGi-enablement of SDO early in the new year. At the moment I can't > > promise anything, but from the notes that you produced about > classloading, > > and the code and comments from Bert, I think there is enough information > > to > > prototype an implementation. I will update the list in the new year > after > > I > > take a more detailed look. > > > > > > Thank you... > > > > Regards, > > > > Rajini > > > > On 12/10/07, kelvin goodson <[EMAIL PROTECTED]> wrote: > > > > > > I'd kind of hoped to be in a position to have a release before the end > > of > > > the year. The JIRA query [1] shows that we have 34 JIRAs in resolved > > state > > > with a fix version of SDO-Next, but I think it would be good to get > the > > > OSGi > > > issues dealt with before a release. Thoughts? > > > > > > Kelvin. > > > > > > [1] > > > > > > > > > https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310210&status=5&status=6&component=12311542&component=12310660&component=12310973&component=12310802&fixfor=12312262&resolution=1&sorter/field=issuekey&sorter/order=DESC&sorter/field=components&sorter/order=ASC&sorter/field=updated&sorter/order=DESC > > > > > > > > > On 29/11/2007, kelvin goodson <[EMAIL PROTECTED]> wrote: > > > > > > > > David, > > > > thanks for the fixes. I'll apply them as soon as I can get to > > > > them. I've been away unwell for most of the last weeks so I have > some > > > > catching up to do. Anything you can do to reduce the JIRA backlog > > > > further would be great, thanks. > > > > > > > > Kelvin. > > > > > > > > On 29/11/2007, David Adcox <[EMAIL PROTECTED]> wrote: > > > > > Kelvin, > > > > > > > > > > I have some free cycles, so I'd like to help knock some things off > > > > > this list for you. I've gone ahead and contributed a patch for > > 1483. > > > > > I'll address 1545 as well. I believe that 1384 is already done. > > > > > > > > > > On Nov 20, 2007 6:36 AM, kelvin goodson <[EMAIL PROTECTED] > > > > > > wrote: > > > > > > What should we be concentrating our efforts on in SDO Java. I > > > posted > > > > > > a while back to suggest we think about the content of a next > > > release. > > > > > > We've had a few fixes go in recently, but I'd like to see more > > > > > > consideration of release content before we crank the handle. It > > > would > > > > > > be great to see a balance of new features and bug fixes. > > > > > > > > > > > > > > > > > > For my part I want to get back to ... > > > > > > TUSCANY-1527 Allow for custom data binding of DataObjects in > a > > > > Swing UI > > > > > > TUSCANY-1493 Snapshot mapping framework to convert > DataObjects > > to > > > > and > > > > > > from Java objects > > > > > > as soon as I can. And I believe that at least 1527 can move > > beyond > > > > > > proof of concept in my sandbox, and become part of the trunk. > > > > > > > > > > > > I've been taking a pass through the SDO java JIRA backlog, and > > > seeing > > > > > > from my perspective what's simple / tricky / big / high priority > > > etc, > > > > > > etc. Of course simplicity is in the eye of the beholder, for > > > > > > example, I don't view the OSGi topic as simple as I don't have > > > > > > experience there, but someone out there may find it so; if so > > > please > > > > > > speak up. The same goes for priority, etc. As you might imagine, > > in > > > my > > > > > > estimation there are no simple high priority JIRAs left, but > > there > > > > > > are a few simple medium priority ones, or simple low priority > ones > > > > > > that would be good to just get out of the way. > > > > > > > > > > > > These are .... > > > > > > > > > > > > Simple Starters > > > > > > =========== > > > > > > TUSCANY-1360 New SDOUtil: Getting the enumeration facet > > > > > > TUSCANY-1178 DynamicTypesFromSchemaTestCase expecting *Object > > > types > > > > to > > > > > > be created > > > > > > TUSCANY-1263 XMLEqualityChecker too strict > > > > > > TUSCANY-1359 New SDOUtil: Upper and lower bound on properties > > > where > > > > > > 'isMany' is true > > > > > > TUSCANY-1384 SequenceAddOpenTest.setUp() needs to check if > type > > > > exists > > > > > > before creating it > > > > > > TUSCANY-1545 Change default XML encoding to "UTF-8". > > > > > > TUSCANY-1659 SDO DateConversion test cases fail under linux > > > > > > > > > > > > > > > > > > Particular Skills JIRAs > > > > > > ================= > > > > > > For anyone with JavaJet experience there's > > > > > > > > > > > > TUSCANY-1483 Static SDO generator: problem with elements > named > > > > internal* > > > > > > which would be simple > > > > > > > > > > > > For someone with maven build experience there > > > > > > TUSCANY-257 recently added file > Interface2JavaGenerator.javais > > > > not > > > > > > compatible with JDK 1.4 > > > > > > > > > > > > For someone with Grobu-Utils and maven skills there's ... > > > > > > TUSCANY-1182 Add multi-threaded test case for data object > > > creation > > > > > > > > > > > > Someone with Axis2 skills > > > > > > TUSCANY-1038 SDO databinding for Axis2 > > > > > > (This may be better done within the Axis2 project) > > > > > > > > > > > > OSGi Skills > > > > > > TUSCANY-1293 SDO does not work with OSGi > > > > > > > > > > > > > > > > > > Biting off something a bit Bigger > > > > > > ======================== > > > > > > For somebody wanting something a bit bigger to take on there's > > > > > > > > > > > > TUSCANY-1192 Preserve demand created global properties > > > > > > TUSCANY-1361 New Util: Validation > > > > > > TUSCANY-1021 CopyHelper and EqualityHelper should handle > > > > ChangeSummary > > > > > > TUSCANY-1817 Improve SDO test infrastructure to > > re-use/re-execute > > > > most > > > > > > dynamic tests as static tests > > > > > > > > > > > > > > > > > > This isn't a full list, and I may post more soon. Please feel > > free > > > to > > > > > > disagree with my assessment and speak up with your own > priorities. > > > > > > Better still step forward to help fix something. I'd be only > too > > > > > > pleased to help you understand what's required. > > > > > > > > > > > > Kelvin. > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > -- Thank you... Regards, Rajini
