ant elder wrote:
Could you say a bit more about why it needs to be a runtime module not just
somewhere like maven-web-junit, and what the issue is in point 3? (as you
can guess my preference is for this to not be in the core runtime :))
...ant
I agree that we should keep this out of the core runtime if possible.
The "get it working now, refactor later" approach sounds attractive
but in practice it's hard to prioritize refactoring something that
already works when we have so many other things that also need to
be done.
Simon
On Feb 4, 2008 9:57 PM, Raymond Feng <[EMAIL PROTECTED]> wrote:
Hi,
I don't have a strong preference. Let's try to get the basic function
working well first. A few points to think about before we refactor it.
1) maven-web-junit is a maven plugin under tools. We need to add another
runtime project under modules folder.
2) host-webapp adds the junit as a runtime dependency which is not great
but
not too bad.
3) Configuring two servlet filters conditionally is a bit complex :-). We
can also disable the /junit unit with an init-parameter "junit.enabled"
set
to false.
Thanks,
Raymond
----- Original Message -----
From: "ant elder" <[EMAIL PROTECTED]>
To: <tuscany-dev@ws.apache.org>
Sent: Monday, February 04, 2008 7:14 AM
Subject: Re: [PROPOSAL] Automate itests for WAR packaging
If this is just for itests then to keep runtime cleaner how about moving
it
all out of the main runtime code into the maven-web-junit module? So
move
WebTestRunner, XMLFormatter, add a new ITestTuscanyServletFilter that
extends the TuscanyServletFilter to add the /junit hook and revert
host-webapp, and the web.xml in the itest/services module can refer to
the
new ITestTuscanyServletFilter?
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
