Raymond Feng wrote:
As the first step, I fixed the code (r619973) to tolerate the case that junit is not present on the classpath. Now the webapp samples should be working as-is now.

How about the following refactoring?

1) Create a new module as "host-webapp-junit" under "modules" folder. (I think it should be under "modules" instead of "tools" since it's the runtime code).

+1

2) Rename WebTestRunner to TuscanyTestServletFilter and extend it from the TuscanyServletFilter

Do we have to?

3) Adjust the maven plugin togenerate the web.xml for itests to use TuscanyTestServletFilter

Do we have to? Can't we just have web.xml just there in the modules?

4) Adjust the itest/pom.xml to reference host-webapp-junit as the dependency for "webapp" profile?

+1
--
Jean-Sebastien

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to