On Mon, Apr 7, 2008 at 8:30 PM, Luciano Resende <[EMAIL PROTECTED]> wrote:
> Comments inline ... > > On Mon, Apr 7, 2008 at 10:43 AM, Simon Laws <[EMAIL PROTECTED]> > wrote: > > On Mon, Apr 7, 2008 at 5:17 PM, Luciano Resende <[EMAIL PROTECTED]> > > wrote: > > > > > > > > > Thanks all for the quick feedback. I'm fixing these issues and should > > > have a RC3a sometime today for review. > > > > > > On Mon, Apr 7, 2008 at 8:51 AM, Simon Laws <[EMAIL PROTECTED] > > > > > wrote: > > > > > > > > On Mon, Apr 7, 2008 at 10:25 AM, ant elder <[EMAIL PROTECTED]> > wrote: > > > > > > > > > On Mon, Apr 7, 2008 at 6:14 AM, Luciano Resende < > [EMAIL PROTECTED]> > > > > > wrote: > > > > > > > > > > > Please review and vote on the 1.2 release artifacts of Tuscany > SCA > > > for > > > > > > Java. > > > > > > > > > > > > The artifacts are available for review at: > > > > > > > > http://people.apache.org/~lresende/tuscany/sca-1.2-RC3/<http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/> > <http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/> > > > <http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/> > > > > > <http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/> > > > > > > > > > > > > > > > > > > This includes the signed binary and source distributions, the > RAT > > > > > report, > > > > > > and the Maven staging repository. > > > > > > > > > > > > The eclipse updatesite for the Tuscany Eclipse plugins is > available > > > at: > > > > > > > http://people.apache.org/~lresende/tuscany/sca-1.2-RC3/updatesite/<http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/updatesite/> > <http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/updatesite/> > > > <http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/updatesite/ > > > > > > > < > http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/updatesite/ > > > > > > > > > > > > > > > > The release tag is available at : > > > > > > > > > > http://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/1.2-RC3/ > > > > > > > > > > > > > > > > > > Looks OK to me, here is my +1. > > > > > > > > > > > > -- > > > > > > Luciano Resende > > > > > > > > > > > > > > > > This looks pretty good to me but the problem with building with > mvn > > > > > prevents > > > > > complete testing and there's a problem with the legal files > being > > > > > duplicated > > > > > in the src distro so we probably need a respin to fix those > things. > > > > > > > > > > The things I've found so far are: > > > > > > > > > > - src distro has got two copies of legal files in top level > folder > > > > > > > > > > - The update site jars NOTICE file has the project name as ${ > pom.name > > > } > > > > > instead of Apache Tuscany > > > > > > > > > > - building samples with mvn in bin dsitro fails with > > > > > java.lang.NoClassDefFoundError: > > > org/apache/tuscany/sca/work/WorkScheduler > > > > > at > > > > > > > > > > > > > > org.apache.tuscany.sca.host.embedded.impl.ReallySmallRuntime.start(ReallySmallRuntime.java:102) > > > > > > > > > > - building src distro fails in modules/core with missing class > > > > > WorkScheduler > > > > > > > > > > - INSTALL file mentions doc folder which missing and does not > mention > > > > > tutorials folder > > > > > > > > > > - tutorial catalog includes a built webapp is that intentional? > And > > > trying > > > > > to deploy that webapp in tomcat gives a SEVERE: Error Starting > SCA > > > WebApp > > > > > Node > > > > > java.lang.ClassNotFoundException: > > > > > > > > > org.apache.tuscany.sca.implementation.node.webapp.NodeWebAppServletHost > > > > > > > > > > - the README in the tutorial folder doesn't give much info and > just > > > points > > > > > to a website page but that page doesn't look finished and gives > > > little > > > > > help > > > > > > > > > > ...ant > > > > > > > > > > > > > Hi Luciano > > > > > > > > Just started checking through RC3. The samples I tried look good. > I had > > > > problems with the maven build of the samples but by adding > > > > > > http://people.apache.org/~lresende/tuscany/sca-1.2-RC3/maven/<http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/maven/> > <http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC3/maven/>as a > maven > > > > > > > > mirror I was able to make progress. > > > > > > > > Looking at the LICENSE file. Things in the lib dir but not in the > > > license > > > > file are; > > > > > > > > stax-api-1.0-2.jar > > > > > > > > Things in the LICENSE file but not in the lib dir are; > > > > > > > > commons-cli-1.0.jar > > > > activemq-core-4.1.1.jar > > > > axis2-adb-codegen-1.3.jar > > > > maven-artifact-2.0.2.jar > > > > maven-artifact-manager-2.0.2.jar > > > > maven-error-diagnostics-2.0.2.jar > > > > maven-model-2.0.2.jar > > > > maven-profile-2.0.2.jar > > > > maven-project-2.0.2.jar > > > > maven-repository-metadata-2.0.2.jar > > > > maven-settings-2.0.2.jar > > > > opensaml-1.1.jar > > > > wagon-file-1.0-alpha-7.jar > > > > wagon-http-lightweight-1.0-alpha-6.jar > > > > wagon-provider-api-1.0-alpha-6.jar > > > > xbean-2.1.0.jar > > > > xmlParserAPIs-2.6.2.jar > > > > jaxen-1.1-1.jar > > > > stax-api-1.0.2.jar > > > > > > > > Before I carry on checking other things, what's the protocol for > making > > > > changes to the 1.2 branch? Shall I report them here and go in and > fix > > > them > > > > or do you want to make the changes yourself? > > > > > > > > Regards > > > > > > > > Simon > > > > > > > > > > > > > > > > -- > > > Luciano Resende > > > Apache Tuscany Committer > > > http://people.apache.org/~lresende<http://people.apache.org/%7Elresende>< > http://people.apache.org/%7Elresende> > > > > > http://lresende.blogspot.com/ > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > Some more comments on RC3... > > > > bin > > LICENSE > > Difference between LICENSE/lib already reported > > Fixed in branch already. > > > NOTICE > > The way that the sca xsd license is referred to is inconsistent when > > compared to the SDO license. Can we replace > > > > "This product also includes software under the OSOA license > > (see the LICENSE file contained in this distribution), with > > the following copyright:" > > > > with > > > > "This product also includes software under the Service Component > > Architecture JavaDoc, > > Interface Definition files and XSD files license, with the following > > copyright:" > > > > Could you elaborate more on your proposal ? Also, looks like the > proposed text might be missing some text ? Maybe a pointer to the SDO > place you used as comparison would help me understand better. I was > looking at the latest 1.1 SDO tag, but not sure I found the right > place. I was just comparing it to the SDO notice that come after it. I took the words from the start of the license [1]. This is not a big deal if you don't like it and I wouldn't -1 for it. > > > > > Need to add > > > > "This product includes software under the Apache License Version 2.0 > > with the following copyright: > > > > Copyright (c) 2003-2004 Jan-Klaas Kollhof > > Copyright (c) 2005 Michael Clark, Metaparadigm Pte Ltd > > > > Please see the LICENSE file present in the root directory of this > > distribution. " > > > > Where is this notice coming from ? Apologies - This refers to the src distro and you can find the file here... modules/binding-jsonrpc/src/main/resources/org/apache/tuscany/sca/binding/jsonrpc/jsonrpc.js > > > > > > /modules now includes tuscany-node2-launcher-webapp-1.2-incubating.war > and > > it also appears as a separate maven artifact > > (Have to admit that I don't know what this is for, although I can > guess) > > It doesn't have license and notice files and the manifest > information is > > different from the module jars. > > Should this really ship as a separate maven artifact? > > > > As for the war license, etc, it's following the same as our sample > apps. But you are right, we should probably not ship this in maven. > > > src > > ships itest/transaction/derbydb > > This is required by transaction (it has the derby db in svn) > > > Got the mvn build problem that has already been reported so can't test > much > > more > > Fixed in branch > > > > > updatesite > > Add a README > > Fixed in the branch. > > > > > Regards > > > > Simon > > > > > > -- > Luciano Resende > Apache Tuscany Committer > http://people.apache.org/~lresende <http://people.apache.org/%7Elresende> > http://lresende.blogspot.com/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > Luciano Sounds like you got most of these already. Couple of answers in line Simon [1] http://www.osoa.org/xmlns/sca/1.0/license.txt
