Passed with 9 +1 binding votes from Ant Elder, Jean-Sebastien Delfino, Raymond Feng, Adriano Crestani, Venkata Krishnan, Mike Edwards, Simon Laws, Simon Nash and myself and 2 +1 non-binding votes from Vamsavardhana Reddy, Dave Sowerby and no -1.
I shall now submit to IPMC review. On Wed, Apr 16, 2008 at 9:09 PM, Simon Nash <[EMAIL PROTECTED]> wrote: > Luciano Resende wrote: > > > Please review and vote on the 1.2 release artifacts of Tuscany SCA for > Java. > > > > The artifacts are available for review at: > > http://people.apache.org/~lresende/tuscany/sca-1.2-RC4/ > > > > This includes the signed binary and source distributions, the RAT report, > > and the Maven staging repository. > > > > The eclipse updatesite for the Tuscany Eclipse plugins is available at: > > http://people.apache.org/~lresende/tuscany/sca-1.2-RC4/updatesite/ > > > > The release tag is available at : > > http://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/1.2-RC4/ > > > > > > Looks OK to me, here is my +1. > > > > > I'm on vacation with extremely limited connectivity so I haven't been > able to give this as thorough a review as I normally would. > > I built the source - OK. > > I checked that TUSCANY-2220 was fixed - OK. > > I tried running some samples - not OK. > > Problem 1: > The sample helloworld-service-jms has the build.xml file from > helloworld-ws-service-jms. The test.jar variable is set to > sample-helloworld-ws-service-jms.jar which does not exist in this > sample's target directory. The project name is also incorrectly > listed as helloworld-ws-service-jms (minor issue). I corrected > these two errors in the build.xml file and the sample ran OK. > > Problem 2 (minor): > I decided to check all the other sample build.xml files to see if > there were any similar problems. The sample helloworld-reference-jms > has a build.xml file with a project name of helloworld-ws-reference-jms > (minor issue). The test.jar variable is correctly set to > sample-helloworld-reference-jms.jar, so the sample runs OK. > > Problem 3: > I found one more build.xml file with a similar problem. This was > implementation-pojo. My best attempts at doing a fix-up similar to > what I did for Problem 1 were not successful. I was able to resolve > the NoClassDefFoundError by editing build.xml, but then I got the > following messages: > > > F:\tuscany-1.2-rc4\tuscany-sca-1.2-incubating\samples\implementation-pojo>ant > ru > n > Buildfile: build.xml > > run: > [java] 17-Apr-2008 04:13:47 > org.apache.tuscany.sca.contribution.processor.E > xtensibleStAXArtifactProcessor read > [java] WARNING: Element {http://pojo}implementation.pojo cannot be > processe > d. ([row,col {unknown-source}]: [26,9]) > [java] 17-Apr-2008 04:13:47 > org.apache.tuscany.sca.contribution.processor.E > xtensibleStAXArtifactProcessor read > [java] WARNING: Element {http://pojo}implementation.pojo cannot be > processe > d. ([row,col {unknown-source}]: [30,9]) > [java] 17-Apr-2008 04:13:47 > org.apache.tuscany.sca.assembly.builder.impl.Co > mpositeBuilderImpl$1 problem > [java] WARNING: No implementation for component: HelloWorldComponent > [java] 17-Apr-2008 04:13:47 > org.apache.tuscany.sca.assembly.builder.impl.Co > mpositeBuilderImpl$1 problem > [java] WARNING: No implementation for component: HelloWorldComponent2 > [java] 17-Apr-2008 04:13:47 > org.apache.tuscany.sca.assembly.builder.impl.Co > mpositeBuilderImpl$1 problem > [java] WARNING: No implementation for component: HelloWorldComponent > [java] 17-Apr-2008 04:13:47 > org.apache.tuscany.sca.assembly.builder.impl.Co > mpositeBuilderImpl$1 problem > [java] WARNING: No implementation for component: HelloWorldComponent2 > [java] Exception in thread "main" org.osoa.sca.ServiceRuntimeException: > No > service is declared on component HelloWorldComponent > [java] at > org.apache.tuscany.sca.core.context.ComponentContextHelper.ge > tSingleService(ComponentContextHelper.java:297) > [java] at > org.apache.tuscany.sca.core.context.ComponentContextImpl.crea > teSelfReference(ComponentContextImpl.java:157) > [java] at > org.apache.tuscany.sca.host.embedded.impl.DefaultSCADomain.ge > tServiceReference(DefaultSCADomain.java:505) > [java] at > org.apache.tuscany.sca.host.embedded.impl.DefaultSCADomain.ge > tService(DefaultSCADomain.java:418) > [java] at > helloworld.HelloWorldClient.main(HelloWorldClient.java:30) > [java] Java Result: 1 > > BUILD SUCCESSFUL > Total time: 1 second > > The final message says "BUILD SUCCESSFUL" but the preceding error > messages make me rather doubtful that this is true. > > Are others able to recreate Problem 1 and Problem 3 from the rc4 > binary distro when running the samples using ant scripts? > > Despite these problems, I am willing to give this release a +1. > Problem 1 is easily fixable by the user (maybe this can be > documented somewhere). Problem 3 is more troubling, but if it only > affects implementation.pojo then I would be OK with the release > despite this issue. Any insights would be much appreciated. > > Simon > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Luciano Resende Apache Tuscany Committer http://people.apache.org/~lresende http://lresende.blogspot.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]