Comments are on the ticket: https://twistedmatrix.com/trac/ticket/7633#comment:14. I forgot to reassign when I did the review earlier today.
On Wed Oct 08 2014 at 7:37:38 PM Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > On Oct 8, 2014, at 2:13 AM, Jonathan Lange <j...@mumak.net> wrote: > > > Done. Not reviewed for style guide compliance, and I haven't run it > locally or on the build slaves. Hope this helps. > > Thanks very much for having a look at this! I'll address the feedback. > > You shouldn't need to review for style-guide compliance, as that's the > twistedchecker buildbot's job. Which, I should mention, is green on the > branch :). > > Also, I already ran the buildbots. You can quickly investigate their > results by looking at the "buildbot" link in the "branch" field of the > ticket description. > > Armed with these two additional pieces of information, would you be > willing to turn this comment into a passing review? ;-) > > -glyph > _______________________________________________ > Twisted-Python mailing list > Twisted-Python@twistedmatrix.com > http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python >
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
