On Oct 8, 2014, at 11:50 AM, Jonathan Lange <j...@mumak.net> wrote:
> Comments are on the ticket:
> https://twistedmatrix.com/trac/ticket/7633#comment:14. I forgot to reassign
> when I did the review earlier today.
Thanks again.
If that was intended to be a full review though, you did leave out one
important step:
As documented in
<https://twistedmatrix.com/trac/wiki/ReviewProcess#Howtobeagoodreviewer>,
When you're done with the review, always say what the next step should be: for
example, if the author is a committer, can they commit after making a few minor
fixes? If your review feedback is more substantial, should they re-submit for
another review?
It looks like a "address these minor issues and merge" review, but given that
you said you didn't have time to look at certain things, I don't want to make
any assumptions.
-g
_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
