On Mon, 31 Mar 2008 10:01:34 -0400 Ben Warren <[EMAIL PROTECTED]> wrote:
> Tor Krill wrote: > > Add phy_info for Vitesse VSC8601. > > Add config option, CFG_VSC8601_SKEWFIX, to enable RGMII skew timing > > compensation. > > > > Signed-off-by: Tor Krill <[EMAIL PROTECTED]> > > > Acked-by: Ben Warren <[EMAIL PROTECTED]> I don't have a Vitesse 8601, so technically I can't ack it, but I can: Reviewed-by: Kim Phillips <[EMAIL PROTECTED]> minor nit: it would be nice if the following: > > +#ifdef CFG_VSC8601_SKEWFIX > > + > > {MIIM_VSC8601_EPHY_CON,MIIM_VSC8601_EPHY_CON_INIT_SKEW,NULL}, > > +#endif were made to have spaces after commas, and flow onto a separate line so as to not be a 96 char line.. Kim ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users