Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: >> Adjust to the current Linux way. >> >> Signed-off-by: Shinya Kuribayashi <[EMAIL PROTECTED]> > ... >> -#define CONFIG_MIPS32 1 /* MIPS32 CPU core */ >> +#define CONFIG_CPU_MIPS32_R1 1 /* MIPS32 CPU core */ > > I have to admit that I don't like this changes. > > We're adding a lot of fine ganularity here
First of all, current CONFIG_MIPS32 defines are useless. We can even remove them. What is fine granularity for, huh? [EMAIL PROTECTED]:~/devel/u-boot.git$ grep -r CONFIG_MIPS32 . ./include/configs/qemu-mips.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */ ./include/configs/dbau1x00.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */ ./include/configs/gth2.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */ ./include/configs/purple.h:#define CONFIG_MIPS32 1 /* MIPS 5Kc CPU core */ ./include/configs/tb0229.h:#define CONFIG_MIPS32 1 /* MIPS 4Kc CPU core */ ./include/configs/pb1x00.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */ ./include/configs/incaip.h:#define CONFIG_MIPS32 1 /* MIPS 4Kc CPU core */ [EMAIL PROTECTED]:~/devel/u-boot.git$ [btw tb0229 is not MIPS32 at all. it's VR4131 based machine.] > What exactly is the reason for all these changes? Which problem are > you trying to fix? It'll be good we could have CPU type specifier so that we can utilize as a compiler/assembler optimization. And why I use CONFIG_CPU_MIPS32_R1, instead of CONFIG_CPU_MIPS32, is due to avoiding #ifdef mess. CONFIG_CPU_MIPS32 is inadequate for this use. We need _R1 or _R2. Linux is doing well with the help of Kconfig. Probably I should have fold this patch and `[MIPS] CPU-dependent compiler/assembler options for optimization' patch into one. Thought? Shinya ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users