Jean-Christophe PLAGNIOL-VILLARD wrote: > On 10:54 Mon 03 Nov , Niklaus Giger wrote: >> The following improvements are made: >> - document bootvx in README >> - fix size too small by one in sprintf >> - changed old (pre 2004) device name ibmEmac to emac >> - boot device may be overriden in board config >> - servername may be defined in board config >> - additional parameters may be defined in board config >> - fixed some line wrappings >> - changed netstal-common.h to use the new settings > Could you split your patch a smallest changeset? How many changeset do you want? Is it sufficient to make two by just isolating the changes in netstal-common.h? <,,.> >> +#ifndef CONFIG_SYS_VXWORKS_BOOT_DEVICE >> #if defined(CONFIG_4xx) >> - sprintf (build_buf, "ibmEmac(0,0)"); >> +#define CONFIG_SYS_VXWORKS_BOOT_DEVICE "emac(0,0)" >> +#elif defined(CONFIG_IOP480) >> +#define CONFIG_SYS_VXWORKS_BOOT_DEVICE "dc(0,0)" >> +#else >> +#define CONFIG_SYS_VXWORKS_BOOT_DEVICE "eth(0,0)" >> +#endif >> +#endif > could we move thie define to an header? Which header shall I use? Is common.h right?
Mmm. Looking at common.h I found that there max is defined with the same meaning as in cmd_elf.h. Probably worth a fix too. Best regards Niklaus _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot